vWAN hub routing preference and autoscale #1468

rozkurt · 2023-11-06T13:59:50Z

Overview/Summary

Added Azure vWAN Routing Preference and Virtual Hub Capacity support for Portal Deployment

This PR fixes/adds/changes/removes

Updated vwan-connectivity.json
Updated portal RI

Breaking Changes

N/A

Testing Evidence

Testing URLs

Azure Public

As part of this Pull Request I have

Checked for duplicate Pull Requests
Associated it with relevant issues, for tracking and closure.
Ensured my code/branch is up-to-date with the latest changes in the main branch
Performed testing and provided evidence.
Ensured contribution guidance is followed.
Updated relevant and associated documentation.
Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

jtracey93

Nice work here @rozkurt

Can we make the small changes I have suggested please

jtracey93 · 2023-11-08T13:50:21Z

eslzArm/eslz-portal.json

+                                "allowedValues": [
+                                    {
+                                        "label": "2",
+                                        "description": "2 Router Infrastructure Units, 3 Gbps Router, Supports 2000 VMs",


Suggested change

"description": "2 Router Infrastructure Units, 3 Gbps Router, Supports 2000 VMs",

"description": "2 Routing Infrastructure Units, 3 Gbps Aggregate Throughput, Supports 2000 VMs",

Can we change all of these to match the table column names here: https://learn.microsoft.com/en-us/azure/virtual-wan/hub-settings#routing-infrastructure-unit-table

jtracey93 · 2023-11-08T13:51:07Z

eslzArm/eslz-portal.json

+                            "filter": false,
+                            "multiLine": true,
+                            "visible":"[and(not(equals(steps('connectivity').enableHub, 'No')), not(equals(steps('connectivity').enableHub, 'nva')), not(equals(steps('connectivity').enableHub, 'vhub')))]",
+                            "toolTip":"Preference used in selecting best path when the virtual hub learns multiple paths to the same destination route-prefix.<a href=\"https://learn.microsoft.com/en-us/azure/virtual-wan/about-virtual-hub-routing-preference\">Virtual hub routing preference</a>.",


Suggested change

"toolTip":"Preference used in selecting best path when the virtual hub learns multiple paths to the same destination route-prefix.<a href=\"https://learn.microsoft.com/en-us/azure/virtual-wan/about-virtual-hub-routing-preference\">Virtual hub routing preference</a>.",

"toolTip":"Preference used in selecting best path when the virtual hub learns multiple paths to the same destination route-prefix.<a href=\"https://learn.microsoft.com/azure/virtual-wan/about-virtual-hub-routing-preference\">Virtual hub routing preference</a>.",

Removing the fixed language to make this more D&I

jtracey93 · 2023-11-08T13:51:28Z

docs/wiki/Whats-new.md

+#### Tooling
+
+- Added virtual hub routing preference support to Portal Accelerator for scenarios where you need to influence routing decisions in virtual hub router towards on-premises. For existing ALZ customers please visit [Configure virtual hub routing preference](https://learn.microsoft.com/en-us/azure/virtual-wan/howto-virtual-hub-routing-preference) for details on how to configure virtual hub routing preference settings.
+- Added virtual hub capacity option to Portal Accelerator which provides an option to select the number of routing infrastracture units. Please visit [Virtual hub capacity](https://learn.microsoft.com/en-us/azure/virtual-wan/hub-settings#capacity) for more details on Azure vWAN Virtual Hub Capacity configuration.


Suggested change

- Added virtual hub capacity option to Portal Accelerator which provides an option to select the number of routing infrastracture units. Please visit [Virtual hub capacity](https://learn.microsoft.com/en-us/azure/virtual-wan/hub-settings#capacity) for more details on Azure vWAN Virtual Hub Capacity configuration.

- Added virtual hub capacity option to Portal Accelerator which provides an option to select the number of routing infrastracture units. Please visit [Virtual hub capacity](https://learn.microsoft.com/azure/virtual-wan/hub-settings#capacity) for more details on Azure vWAN Virtual Hub Capacity configuration.

Removing the fixed language to make this more D&I

jtracey93 · 2023-11-08T13:51:37Z

docs/wiki/Whats-new.md

+
+#### Tooling
+
+- Added virtual hub routing preference support to Portal Accelerator for scenarios where you need to influence routing decisions in virtual hub router towards on-premises. For existing ALZ customers please visit [Configure virtual hub routing preference](https://learn.microsoft.com/en-us/azure/virtual-wan/howto-virtual-hub-routing-preference) for details on how to configure virtual hub routing preference settings.


Suggested change

- Added virtual hub routing preference support to Portal Accelerator for scenarios where you need to influence routing decisions in virtual hub router towards on-premises. For existing ALZ customers please visit [Configure virtual hub routing preference](https://learn.microsoft.com/en-us/azure/virtual-wan/howto-virtual-hub-routing-preference) for details on how to configure virtual hub routing preference settings.

- Added virtual hub routing preference support to Portal Accelerator for scenarios where you need to influence routing decisions in virtual hub router towards on-premises. For existing ALZ customers please visit [Configure virtual hub routing preference](https://learn.microsoft.com/en-us/azure/virtual-wan/howto-virtual-hub-routing-preference) for details on how to configure virtual hub routing preference settings.

Removing the fixed language to make this more D&I

jtracey93 · 2023-11-08T13:51:56Z

eslzArm/eslz-portal.json

+                            "filter": false,
+                            "multiLine": true,
+                            "visible":"[and(not(equals(steps('connectivity').enableHub, 'No')), not(equals(steps('connectivity').enableHub, 'nva')), not(equals(steps('connectivity').enableHub, 'vhub')))]",
+                            "toolTip": "Routing infrastructure units determine the minimum throughput of the Virtual WAN hub router and the number of Virtual Machines that can be deployed in Virtual Networks connected to the Virtual WAN hub. Two routing infrastructure units are included at no extra cost with a deployment of a hub.<a href=\"https://learn.microsoft.com/en-us/azure/virtual-wan/hub-settings#capacity\">Virtual Hub Capacity</a>.",


Suggested change

"toolTip": "Routing infrastructure units determine the minimum throughput of the Virtual WAN hub router and the number of Virtual Machines that can be deployed in Virtual Networks connected to the Virtual WAN hub. Two routing infrastructure units are included at no extra cost with a deployment of a hub.<a href=\"https://learn.microsoft.com/en-us/azure/virtual-wan/hub-settings#capacity\">Virtual Hub Capacity</a>.",

"toolTip": "Routing infrastructure units determine the minimum throughput of the Virtual WAN hub router and the number of Virtual Machines that can be deployed in Virtual Networks connected to the Virtual WAN hub. Two routing infrastructure units are included at no extra cost with a deployment of a hub.<a href=\"https://learn.microsoft.com/azure/virtual-wan/hub-settings#capacity\">Virtual Hub Capacity</a>.",

Removing the fixed language to make this more D&I

@jtracey93, thanks for the comments. Just fixed them as you've suggested and pushed the changes into my branch. Could you please review again?

Springstone · 2023-11-08T15:36:38Z

eslzArm/subscriptionTemplates/vwan-connectivity.json

+                                                "sku": "[variables('vhubsku')]",
+                                                "hubRoutingPreference": "[parameters('vWANHubRoutingPreference')]",
+                                                "virtualRouterAutoScaleConfiguration": {
+                                                "minCapacity": "[int(parameters('vWANHubCapacity'))]"


Please address indenting here.

jtracey93 · 2023-11-08T15:32:53Z

eslzArm/subscriptionTemplates/vwan-connectivity.json

+                                                "hubRoutingPreference": "[parameters('vWANHubRoutingPreference')]",
+                                                "virtualRouterAutoScaleConfiguration": {
+                                                "minCapacity": "[int(parameters('vWANHubCapacity'))]"
+                                                }


Suggested change

"hubRoutingPreference": "[parameters('vWANHubRoutingPreference')]",

"virtualRouterAutoScaleConfiguration": {

"minCapacity": "[int(parameters('vWANHubCapacity'))]"

}

"hubRoutingPreference": "[parameters('vWANHubRoutingPreference')]",

"virtualRouterAutoScaleConfiguration": {

"minCapacity": "[int(parameters('vWANHubCapacity'))]"

}

@jtracey93, just pushed one more change to address this one!

eslzArm/eslz-portal.json

Recep Ozkurt added 20 commits October 30, 2023 09:55

Added vWAN Hub capacity to UI

a57df46

.

a919273

Enabled virtualRouterAutoScaleConfig on vWAN HUB

8af8477

.

efa517d

.

52d0e3a

.

ed97f2c

.

6738245

Updated vWANHubCapacity Allowed Values

75aeeb0

.

d47b2f7

.

abc7e4c

Modified tooltip to include reference URL

2fadb90

Added HubRouting Preference to UI

41d0513

Added hubroutingpreference config

379eb8e

Updated API version to 2021-08-01 for VirtualHubs

7a4cf12

Modified values for Hub Routing Preference

f1b7f48

.

126a628

.

525596b

Updated API version for virtualHubs to the latest

27aa420

Updated what's new with Nov 2023 updates

4ba9908

.

c0b7d67

rozkurt marked this pull request as ready for review November 6, 2023 14:04

rozkurt requested a review from a team as a code owner November 6, 2023 14:04

Merge branch 'main' into vWAN_HUB_RoutingPreference_and_Autoscale

5c803c7

jtracey93 requested changes Nov 8, 2023

View reviewed changes

microsoft-github-policy-service bot added the Needs: Author Feedback label Nov 8, 2023

Fixed minor issues based on D&I concens

0ece7af

microsoft-github-policy-service bot removed the Needs: Author Feedback label Nov 8, 2023

This comment was marked as outdated.

Sign in to view

Springstone added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label Nov 8, 2023

Springstone reviewed Nov 8, 2023

View reviewed changes

jtracey93 requested changes Nov 8, 2023

View reviewed changes

microsoft-github-policy-service bot added the Needs: Author Feedback label Nov 8, 2023

added tabs as per the feedback

4dcb9c7

rozkurt dismissed Springstone’s stale review via 4dcb9c7 November 8, 2023 16:24

rozkurt had a problem deploying to csu-rw November 8, 2023 16:24 — with GitHub Actions Error

microsoft-github-policy-service bot removed the Needs: Author Feedback label Nov 8, 2023

jtracey93 requested changes Nov 9, 2023

View reviewed changes

eslzArm/eslz-portal.json Outdated Show resolved Hide resolved

eslzArm/eslz-portal.json Outdated Show resolved Hide resolved

microsoft-github-policy-service bot added the Needs: Author Feedback label Nov 9, 2023

Apply suggestions from code review

2abdc9f

jtracey93 had a problem deploying to csu-rw November 9, 2023 09:25 — with GitHub Actions Error

Merge branch 'main' into vWAN_HUB_RoutingPreference_and_Autoscale

7f64585

jtracey93 had a problem deploying to csu-rw November 9, 2023 09:26 — with GitHub Actions Error

jtracey93 reviewed Nov 9, 2023

View reviewed changes

eslzArm/eslz-portal.json Outdated Show resolved Hide resolved

Update eslzArm/eslz-portal.json

1e79d53

jtracey93 temporarily deployed to csu-rw November 9, 2023 09:31 — with GitHub Actions Inactive

jtracey93 approved these changes Nov 9, 2023

View reviewed changes

jtracey93 removed the Needs: Author Feedback label Nov 9, 2023

jtracey93 merged commit e687bbb into Azure:main Nov 9, 2023
4 checks passed

rozkurt deleted the vWAN_HUB_RoutingPreference_and_Autoscale branch November 9, 2023 13:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vWAN hub routing preference and autoscale #1468

vWAN hub routing preference and autoscale #1468

rozkurt commented Nov 6, 2023 •

edited

Loading

jtracey93 left a comment

jtracey93 Nov 8, 2023

jtracey93 Nov 8, 2023

jtracey93 Nov 8, 2023

jtracey93 Nov 8, 2023

jtracey93 Nov 8, 2023

rozkurt Nov 8, 2023

This comment was marked as outdated.

Springstone Nov 8, 2023

jtracey93 Nov 8, 2023

rozkurt Nov 8, 2023

	"description": "2 Router Infrastructure Units, 3 Gbps Router, Supports 2000 VMs",
	"description": "2 Routing Infrastructure Units, 3 Gbps Aggregate Throughput, Supports 2000 VMs",

	"toolTip":"Preference used in selecting best path when the virtual hub learns multiple paths to the same destination route-prefix.<a href=\"https://learn.microsoft.com/en-us/azure/virtual-wan/about-virtual-hub-routing-preference\">Virtual hub routing preference</a>.",
	"toolTip":"Preference used in selecting best path when the virtual hub learns multiple paths to the same destination route-prefix.<a href=\"https://learn.microsoft.com/azure/virtual-wan/about-virtual-hub-routing-preference\">Virtual hub routing preference</a>.",

	- Added virtual hub capacity option to Portal Accelerator which provides an option to select the number of routing infrastracture units. Please visit [Virtual hub capacity](https://learn.microsoft.com/en-us/azure/virtual-wan/hub-settings#capacity) for more details on Azure vWAN Virtual Hub Capacity configuration.
	- Added virtual hub capacity option to Portal Accelerator which provides an option to select the number of routing infrastracture units. Please visit [Virtual hub capacity](https://learn.microsoft.com/azure/virtual-wan/hub-settings#capacity) for more details on Azure vWAN Virtual Hub Capacity configuration.


		#### Tooling

		- Added virtual hub routing preference support to Portal Accelerator for scenarios where you need to influence routing decisions in virtual hub router towards on-premises. For existing ALZ customers please visit [Configure virtual hub routing preference](https://learn.microsoft.com/en-us/azure/virtual-wan/howto-virtual-hub-routing-preference) for details on how to configure virtual hub routing preference settings.

vWAN hub routing preference and autoscale #1468

vWAN hub routing preference and autoscale #1468

Conversation

rozkurt commented Nov 6, 2023 • edited Loading

Overview/Summary

This PR fixes/adds/changes/removes

Breaking Changes

Testing Evidence

Testing URLs

Azure Public

As part of this Pull Request I have

jtracey93 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozkurt commented Nov 6, 2023 •

edited

Loading